Replace solrizer reference so that feature works with hyrax 3+ #700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
approved these changes
Jan 10, 2023
|
I don't understand what the "PR has required labels" rule requires me to change? Also wanted to make sure we are okay with the hyrax version requirement going up, as discussed above |
Bulkrax has the following requirement:
|
…ackwards compatability
|
I've updated this PR to make it backwards compatible with older versions of hyrax. Could someone trigger the workflows again? |
orangewolf
approved these changes
Jan 14, 2023
sephirothkod
approved these changes
Jan 17, 2023
bkiahstroud
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses:
#699
This change might not work with hyrax < 2.8, since it looks like solrizer got merged into activefedora in 12.0.0, so if we need to support those versions of hyrax we will likely need to add some logic in here to decide whether to use solrizer or activefedora.
I also suspect this code might not be getting fully tested, since bulkrax is using hyrax 3, but no tests seem to be impacted by this issue.